Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring to AccessChangeQuoteControl and it's Unit Tests #29670

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Minor refactoring to AccessChangeQuoteControl and it's Unit Tests #29670

merged 1 commit into from
Aug 20, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Aug 18, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Improve the Unit Tests, adjust the plugin.
Introduced : void to return type of plugin, that does not require from us to make extra assertions in Unit Tests to the return type.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Minor refactoring to AccessChangeQuoteControl and it's Unit Tests #29672: Minor refactoring to AccessChangeQuoteControl and it's Unit Tests

@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Aug 19, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Cleanup labels Aug 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8027 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 19, 2020
Closed
4 tasks
@engcom-Alfa engcom-Alfa self-assigned this Aug 19, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Actual Result: ✔️ We've got a StateException "Invalid state change requested"

2020-08-19_13-13

@engcom-Charlie engcom-Charlie self-assigned this Aug 19, 2020
@engcom-Charlie engcom-Charlie removed the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 19, 2020
@engcom-Charlie engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. labels Aug 19, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 20, 2020
@sidolov
ENGCOM-8027: Minor refactoring to AccessChangeQuoteControl and it's U…
3c4b977 
…nit Tests #29670
@magento-engcom-team magento-engcom-team merged commit 5374385 into magento:2.4-develop Aug 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 20, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: Quote Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Minor refactoring to AccessChangeQuoteControl and it's Unit Tests
5 participants
@lbajsarowicz @magento-engcom-team @ihor-sviziev @engcom-Alfa @engcom-Charlie